Add Gen IV Great Marsh changing encounters#1499
Add Gen IV Great Marsh changing encounters#1499Machine-Maker wants to merge 1 commit intoPokeAPI:masterfrom
Conversation
jemarq04
left a comment
jemarq04
left a comment
There was a problem hiding this comment.
I've been taking a look at these but I think before I do an in-depth review I'd like you to manually go through these yourself. From an initial glance, rates seem to be incorrect and I'm already seeing duplicates from my first look at Area 1 (e.g. Wooper).
I've made a couple other comments below.
| 176,17,friend-safari-slot-1,1 | ||
| 177,17,friend-safari-slot-2,1 | ||
| 178,17,friend-safari-slot-3,1 | ||
| 179,18,great-marsh-daily-slot-0-of-32,1 |
There was a problem hiding this comment.
I'm not sure I like how these are named (but I'm not sure how else to describe the difference in rates) so we can leave that. That being said, what would a rate of 0/32 for a daily spawn mean? I think this was likely a mistake.
There was a problem hiding this comment.
Ah, if this is for the default field I'd rather something similar to the story-progress condition and name it great-marsh-daily-slot-none, as if you don't check the binoculars you don't have any daily spawn added in to the encounter pool.
| 179,18,great-marsh-daily-slot-0-of-32,1 | |
| 179,18,great-marsh-daily-slot-none,1 |
| 179,9,0 of 32 | ||
| 180,9,1 of 32 | ||
| 181,9,2 of 32 | ||
| 182,9,3 of 32 | ||
| 183,9,5 of 32 | ||
| 184,9,Before National Pokédex | ||
| 185,9,4 of 32 | ||
| 186,9,15 of 32 |
There was a problem hiding this comment.
I think these should be a bit more verbose, like the other entries in the file
2 participants
Change description
Closes #1496
AI coding assistance disclosure
Claude Code helped me analyze decompiled diamond and platinum repos. Also generated the big huge changes based on how they work.
Contributor check list